Fix clippy warning for enums that impl Copy #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate this PR; as you note I've come to the opinion that clippy should just be disabled for generated code. I hear you that it only adds a single new case... but I don't think it's the right approach to chase these... even when the code to do so is relatively minimal. If you feel like I'm wrong or this is the wrong approach please let me know. Otherwise my inclination is to close this PR. |
|
It's all good. It's your project! I just appreciate the upgrades to it. I wrote up the code locally, and then saw your comment when I opened the PR. I personally think it could be a valid goal to get the generated code to pass clippy, but i understand your stance and it's simple enough to disable clippy on the module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the definition of
From<&self>to explicitly use de-referencing instead of clone.I implemented this before I saw your comment on this PR #502 where you say you don't believe on getting clippy to pass on the derived code if it means the code becomes more complicated.
Personally I think that since this code only adds a single branch condition it may still be worth taking. It's up to you to decide if you want to take it.
Either way, now that I know the stance of the crate I will disable clippy on generated code from this library.
Thanks for your work!