-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitlab SAST Reporter #3610
base: main
Are you sure you want to change the base?
Add Gitlab SAST Reporter #3610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have CI experience with GitLab, so can't review if it is the right thing that is done.
For your comments questioning if we should extract SARIF functionality in another file/class, I agree that it can be a good idea if it's possible, but I don't have it as a strong requirement for this specific PR, it can be in another one or this one.
And thanks for sharing this, more people will benefit from it, that's the goal of Megalinter, to combine the efforts of setting up many linters and using them all easily in CI, without every project having to reinvent the wheel to make it usable. |
Update severity handling and default values so Gitlab handles the report better
I don't know how to continue with this one, it's not my skillset |
@TommyE123 since you seem to be using GitLab casually, would you mind giving your opinion on this, and if it is correct to merge as is? It's been waiting a bit |
@TommyE123 what does the thumbs up reaction to my comment mean? That you will do, or it is an approval/review, that it is a solution adapted for this environment? |
Means I can have a look 🙂 |
Sorry I'm late :) This PR is great and i'd love to merge it, but there are additional updates to complete :)
|
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
Anyone wanting to complete this nice PR to apply my comments ? 😋 |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
Add Gitlab SAST reporter
Created a PR for a Gitlab SAST reporter I made and use on our private Gitlab instance. Can't promise I'll have time to fix it up or anything but thought you guys might like to take what I've done so far and run with it :)