Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dishwashers: more sensor adjustments #194

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Dishwashers: more sensor adjustments #194

merged 8 commits into from
Jan 20, 2025

Conversation

TheSimpleZ
Copy link
Contributor

@TheSimpleZ TheSimpleZ commented Jan 18, 2025 •
edited
Loading

  • Make all alarms diagnostics sensors. They don't seem to work anyway. They always show ok.
  • Fix switches for interior light at power off, super rinse aid, and tab setting.
  • Change Rinse_aid_refill and Auto_dose_refill to binary sensors of type problem. These show when you need to refill the rinse aid/dish wash, not the alarm.
  • Fix order of stop/start in translations

@oyvindwe
Copy link
Owner

oyvindwe commented Jan 19, 2025 •
edited
Loading

Thanks! Are you able to sync the changes to the other 015-*.yaml files as well? (My dishwasher changed from 000 to dishwasher-60.2 a while ago - I suspect a firmware update).

@TheSimpleZ
Copy link
Contributor Author

Sure, ill do it sometime today :)
Would you like me to do that for all future changes? I havent done it so far because im not sure it will work on your firmware, i can't really test it.

@TheSimpleZ
Copy link
Contributor Author

TheSimpleZ commented Jan 19, 2025 •
edited
Loading

Synced dishwasher mapping files and also fixed some inconsistencies with icons and quotes (no quoting necessary for icons, use double quote everywhere else).

@oyvindwe
Copy link
Owner

I havent done it so far because im not sure it will work on your firmware, i can't really test it.

The only difference I've seen in the list properties is that properties for feature that my dishwasher does not have were removed, so I think it was a nice cleanup. I think it's OK to merge!

Thank's again for your contribution!

@oyvindwe oyvindwe merged commit 25358fd into oyvindwe:main Jan 20, 2025
1 check passed
@oyvindwe oyvindwe changed the title More sensor adjustments Dishwashers: more sensor adjustments Jan 20, 2025
@oyvindwe oyvindwe mentioned this pull request Jan 20, 2025
Merged
gafderks added a commit to gafderks/connectlife-ha that referenced this pull request Jan 20, 2025
@gafderks
Integrated upstream changes from oyvindwe#194
c0e1130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSimpleZ @oyvindwe