generic update service #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindwe
reviewed
Jan 20, 2025
oyvindwe
reviewed
Jan 21, 2025
| SERVICE_SET_ACTION = "set_action" | ||
| SERVICE_UPDATE = "UPDATE" |
There was a problem hiding this comment.
Should the value here be lowecased., ie. "update"?
There was a problem hiding this comment.
Yes, good catch. Fixed.
That happened during a search and replace. It's nice to keep it consistent, although I don't think it really matters, it still works on my installation.
oyvindwe
approved these changes
Jan 21, 2025
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a generic update action that can target any device and will send the properties as a json.
Properties are provided in yaml format to the action.
Allows users to experiment with the API easily and extend the functionality of the integration without waiting for updates.
Also fixed inconsistent spaces between strings.json and en.json translation file. Strings used 2, en used 4. Now they both use 2.
Example:
