Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team,
In our project, we're using embedded Redis instances with fixed ports and we occasionally encounter situations, when the Redis instance is not terminated properly leaving the port busy after the JVM is shut down, forcing us in turn to do
kill -9
.With this PR I'd like to introduce a builder flag for standalone, sentinel and cluster that enables force-stopping of the instance by passing a
SIGKILL
viaProcess#destroyForcibly()
instead a gracefulSIGTERM
. The new config would be enabled solely on Java side like this:Apart from this change, I've also taken upon myself the liberty of doing a bit of a clean-up:
<prerequisites>
)All changes introduced go in separate commits, let me know if you want to go with some of them and not accept others or to squash them into bigger change sets.