Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow force closing in any state #128

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Allow force closing in any state #128

merged 2 commits into from
Jul 26, 2023

Conversation

Tibo-lg
Copy link
Contributor

@Tibo-lg Tibo-lg commented Jul 21, 2023 •
edited
Loading

This PR makes it possible to force close a sub channel in (almost) every states.

Closes #113

@Tibo-lg Tibo-lg force-pushed the feature/ln-dlc/close-in-all-state branch from a88dbd1 to 5244bf6 Compare July 21, 2023 05:19
@luckysori luckysori self-requested a review July 21, 2023 05:41
@luckysori luckysori assigned Tibo-lg and unassigned luckysori Jul 21, 2023
@Tibo-lg Tibo-lg force-pushed the feature/ln-dlc/close-in-all-state branch from 5244bf6 to 47e73e7 Compare July 21, 2023 11:39
luckysori
luckysori approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The solution turned out to be not so complicated. I left questions and a few comments hoping to make things a bit clearer. Nothing blocking AFAICT.

Obviously the tests are getting quite messy, but we can tackle that separately.

dlc-manager/src/channel/mod.rs Outdated Show resolved Hide resolved
dlc-manager/src/channel/mod.rs Outdated Show resolved Hide resolved
dlc-manager/src/subchannel/mod.rs Outdated Show resolved Hide resolved
dlc-manager/src/subchannel/mod.rs Show resolved Hide resolved
dlc-manager/src/subchannel/mod.rs Outdated Show resolved Hide resolved
dlc-manager/src/sub_channel_manager.rs Show resolved Hide resolved
dlc-manager/src/sub_channel_manager.rs Outdated Show resolved Hide resolved
dlc-manager/src/sub_channel_manager.rs Show resolved Hide resolved
dlc-manager/src/sub_channel_manager.rs Outdated Show resolved Hide resolved
dlc-manager/src/sub_channel_manager.rs Show resolved Hide resolved
@luckysori luckysori mentioned this pull request Jul 24, 2023
Merged
@Tibo-lg Tibo-lg force-pushed the feature/ln-dlc/close-in-all-state branch from 47e73e7 to 2013ad4 Compare July 24, 2023 05:33
luckysori
luckysori approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can merge!

@Tibo-lg Tibo-lg merged commit 5f899ab into feature/ln-dlc-channels Jul 26, 2023
This was referenced Jul 27, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysori luckysori luckysori approved these changes

Assignees

@Tibo-lg Tibo-lg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tibo-lg @luckysori