feat: implement POST/PUT support for protocol file uploads with enhanced stream handling

[akhileshthite]

Implementing the readBody from:
https://github.com/AgregoreWeb/agregore-browser/blob/master/app/protocols/fetch-to-handler.js

IPFS handler:

It's publishing but when I try to access the IPFS CID, it downloads a file instead of opening the content, the file looks like this:

------WebKitFormBoundarynTM5GoLOUy5xJ7Dv
Content-Disposition: form-data; name="file"; filename="index.html"
Content-Type: text/html


------WebKitFormBoundarynTM5GoLOUy5xJ7Dv--

Hyper handler:

That's also publishing but when clicked on the hyper URL it shows empty index.

Error in [object File]: TypeError: input.subarray(...).equals is not a function at multipartFormDataParser (node:internal/deps/undici/undici:3830:84) at node:internal/deps/undici/undici:4247:34 at successSteps (node:internal/deps/undici/undici:4288:27) at consumeBody (node:internal/deps/undici/undici:4294:9) at _Request.formData (node:internal/deps/undici/undici:4242:18) at Object.putFiles [as handler]

[RangerMauve]

What are you using to upload files? If you're using a <form> or FormData then you need to parse the body. e.g.: https://github.com/RangerMauve/hypercore-fetch/blob/master/index.js#L402

I currently parse the form data using the built in Request API in node.js

[RangerMauve]

you shouldn't be concatenating the response on a single buffer like that, it'll lag your computer on large files. You should return the stream of the body in the callback instead.

[akhileshthite]

74c7aae

[akhileshthite]

With large files:

Error in divine_reflections.mp4: HypercoreError: BAD_ARGUMENT: Appended block exceeds the maximum suggested block size at Hypercore.append

[RangerMauve]

Instead of doing a concat you should pass a byte stream. Else it'll lag on large files

[akhileshthite]

7ad1f64

[akhileshthite]

Works with large files

[akhileshthite]

What are you using to upload files? If you're using a <form> or FormData then you need to parse the body. e.g.: https://github.com/RangerMauve/hypercore-fetch/blob/master/index.js#L402

I currently parse the form data using the built in Request API in node.js

I'm testing it on the agregore tutorials:

peersky://p2p/upload/index:
https://github.com/p2plabsxyz/peersky-browser/tree/upload/src/pages/p2p/upload

peersky://p2p/editor/index:
https://github.com/p2plabsxyz/peersky-browser/tree/upload/src/pages/p2p/editor

Getting this after implementing the changes:

Handling request: POST hyper://localhost/?key=drag-and-drop
Headers: {
  'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) peersky-browser/1.0.0 Chrome/126.0.6478.183 Electron/31.3.0 Safari/537.36',
  Accept: '*/*'
}
Body content read for non-multipart request.
Response received: 200
Handling request: PUT hyper://w5yhg6uct7tip4y9nazk8o51b8fs4nnfk6fnxeci1o4ck1eoxxby/
Headers: {
  'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) peersky-browser/1.0.0 Chrome/126.0.6478.183 Electron/31.3.0 Safari/537.36',
  'Content-Type': 'multipart/form-data; boundary=----WebKitFormBoundarysXA9s7VnYGTXyccE',
  Accept: '*/*'
}
Error handling form data: TypeError: request.formData is not a function
    at handleMultipartFormData (file:///Users/akhileshthite/Desktop/peersky-browser/src/protocols/hyper-handler.js:19:36)
    at AsyncFunction.protocolHandler (file:///Users/akhileshthite/Desktop/peersky-browser/src/protocols/hyper-handler.js:75:31)
Failed to handle Hyper request: TypeError: request.formData is not a function
    at handleMultipartFormData (file:///Users/akhileshthite/Desktop/peersky-browser/src/protocols/hyper-handler.js:19:36)
    at AsyncFunction.protocolHandler (file:///Users/akhileshthite/Desktop/peersky-browser/src/protocols/hyper-handler.js:75:31)

On the page:

Error in [object FileList]:
hyper://w5yhg6uct7tip4y9nazk8o51b8fs4nnfk6fnxeci1o4ck1eoxxby/

Index of /
../

[RangerMauve]

I think you should spend a bit more time debugging the stack trace to see why the error is happening.