Simplify format.sh by Invoking prebuilt buildifier binary via Bazel. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #162. Signed-off-by: Steffen Smolka <[email protected]>
jafingerhut
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
I do not know enough about the contents of the WORKSPACE.bazel file to review it intelligently, but I have confirmed that I can run the new format.sh proposed in this PR, as long as the system has clang-format and bazelisk installed. I tested only on Ubuntu 24.04 aarch64 system so far, but I suspect that plus the CI test on probably an Ubuntu 24.04 x86_64 system should be enough to proceed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162.