-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final changes for 1.4.1 release, including version updates. #507
Conversation
I think #480 (comment) indicates one more change to the .bib is in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, needs .bib updates.
Thanks for the clarification. I just pushed a commit to update references.bib. |
I used #327 as an example, and followed the instructions mentioned in #327. Signed-off-by: smolkaj <[email protected]>
2a6c6fb
to
4bdf2e6
Compare
I'm not 100% sure these links are correct, since the version number of the spec is not mentioned in the URL. I sent a quick email to @jonathan-dilorenzo and Ryan Goodfellow to find out. |
Andy had provided what he thought were the latest links here: #480 (comment) |
Thanks. They just released 1.2.5, but https://p4.org/p4-spec/docs/P4-16-v1.2.5.html does not seem to work. cc @jonathan-dilorenzo |
Yeah, the 1.2.5 link goes to an article about CREASE. And the browser tab says "Page not found." So this is the default page to show on p4.org when page isn't found? Weird. |
Signed-off-by: smolkaj <[email protected]>
Signed-off-by: smolkaj <[email protected]>
b13871a
to
ffd0834
Compare
Alright, links are fixed. Anything else? @chrispsommers @jafingerhut |
LGTM, looks like a CI failure though. |
Oh no, not again :( Will fix for now by killing the cache and rebuilding, but looks like we need to find a better fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have no knowledge to do any intelligent review of the changes to the file WORKSPACE.bazel, but all of the other changes I reviewed look good.
@smolkaj Did this actually get done? I don't find 1.5.0 anywhere. I think this is a step after publishing 1.4.1, which is done. I think the ultimate outcome would be to see 1.5.0 in the "working draft:" |
I used #327 as an example, and followed the instructions mentioned in #480.
Fixed #480.
cc @antoninbas