Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for 1.4.1 release, including version updates. #507

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

smolkaj
Copy link
Member

@smolkaj smolkaj commented Oct 11, 2024

I used #327 as an example, and followed the instructions mentioned in #480.

Fixed #480.

cc @antoninbas

@chrispsommers
Copy link
Collaborator

I think #480 (comment) indicates one more change to the .bib is in order.

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, needs .bib updates.

@smolkaj
Copy link
Member Author

smolkaj commented Oct 15, 2024

Thanks for the clarification. I just pushed a commit to update references.bib.

I used #327 as an example, and followed the instructions mentioned in #327.

Signed-off-by: smolkaj <[email protected]>
@smolkaj
Copy link
Member Author

smolkaj commented Oct 15, 2024

I'm not 100% sure these links are correct, since the version number of the spec is not mentioned in the URL. I sent a quick email to @jonathan-dilorenzo and Ryan Goodfellow to find out.

@chrispsommers
Copy link
Collaborator

Andy had provided what he thought were the latest links here: #480 (comment)

@smolkaj
Copy link
Member Author

smolkaj commented Oct 15, 2024

Thanks. They just released 1.2.5, but https://p4.org/p4-spec/docs/P4-16-v1.2.5.html does not seem to work. cc @jonathan-dilorenzo

@chrispsommers
Copy link
Collaborator

chrispsommers commented Oct 15, 2024

Yeah, the 1.2.5 link goes to an article about CREASE. And the browser tab says "Page not found." So this is the default page to show on p4.org when page isn't found? Weird.

@smolkaj
Copy link
Member Author

smolkaj commented Oct 19, 2024

Alright, links are fixed. Anything else? @chrispsommers @jafingerhut

@chrispsommers
Copy link
Collaborator

LGTM, looks like a CI failure though.

@smolkaj
Copy link
Member Author

smolkaj commented Oct 19, 2024

Oh no, not again :( Will fix for now by killing the cache and rebuilding, but looks like we need to find a better fix.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have no knowledge to do any intelligent review of the changes to the file WORKSPACE.bazel, but all of the other changes I reviewed look good.

@smolkaj smolkaj merged commit 36e8b46 into main Oct 21, 2024
6 checks passed
@smolkaj smolkaj deleted the release-1.4.1 branch October 21, 2024 20:39
@chrispsommers
Copy link
Collaborator

chrispsommers commented Oct 23, 2024

@smolkaj Did this actually get done? I don't find 1.5.0 anywhere. I think this is a step after publishing 1.4.1, which is done.
image

I think the ultimate outcome would be to see 1.5.0 in the "working draft:"
https://p4.org/p4-spec/docs/p4runtime-spec-working-draft-html-version.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut release 1.4.0
3 participants