Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new features and solve test fails #89

Closed
wants to merge 3 commits into from
Closed

Adding new features and solve test fails #89

wants to merge 3 commits into from

Conversation

cgmpinos
Copy link

I have added the div and mod operators for integer numbers for #88.
calculator

@cgmpinos cgmpinos changed the title Adding div and mod operations Adding new features and solve test fails Feb 14, 2023
@cgmpinos
Copy link
Author

I have also

  1. added pi button (since the calculator has sin,cos and tan functions, i think pi button would be necessary)
  2. added x factorial (x!) operation and the necessary tests to check its function
  3. solved the tests of sin, cos and tan that failed (sin, cos and tan did not calculate the right results, so i removed Math.toRadians function and now the tests, which were not written by me, pass)
    calculator2

@pH-7
Copy link
Owner

pH-7 commented Mar 11, 2023

Hi @cgmpinos

Thanks very much for those changes! I really appreciate your time improving the calculator!! 💯

Could you just let me know on what Java version you have tested your changes?

Can you also commit SimpleJavaCalculator.jar containing your new changes, and run it?

To do so, you can generate a new jar file with the following CLI command when you are in the src/ directory jar cmvf ../manifest.mf ../SimpleJavaCalculator.jar simplejavacalculator/*.class

@pH-7
Copy link
Owner

pH-7 commented Mar 14, 2023

Let me know @cgmpinos when you can get back to this. That way, I will be able to approve and merge your work to the main branch.

Thanks!
Have a great day!

@pH-7
Copy link
Owner

pH-7 commented Mar 16, 2023

Hey @cgmpinos,

Hope you are still doing well!

I’ve noticed you have two very minor conflicts to be fixed 🙂 Just give me a shout when all done.

Have a great Friday!🎉

@cgmpinos cgmpinos closed this by deleting the head repository Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants