This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Adds a theme for Dark Mode. #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing as how this is accessibility-related, I thought it made some sense to offer a dark mode option.
joeyciechanowicz
suggested changes
Aug 19, 2019
lib/report.html
Outdated
| <style> | ||
| @media (prefers-color-scheme: light), | ||
| (prefers-color-scheme: no-preference) { | ||
| :root { |
There was a problem hiding this comment.
Can the light set of colors be defined as the default, then overridden if the user uses dark-mode?
That way we can support browsers that allow CSS variables, but that don't yet support preferes-color-scheme
joeyciechanowicz
added
the
status: work required
(Only took me like 8 months to get around to it!)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing as how this is accessibility-related, I thought it made some sense to offer a dark mode option.