Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webpack command #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hnzlmnn
Copy link

@hnzlmnn hnzlmnn commented Nov 28, 2019

Added the ability to unpack webpack bundles into source directory. Could be implementing #11. For now, I created an argument switch to enable the feature as I only tested with a handful of webpack bundles.

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2019

This pull request introduces 1 alert when merging 84fdd74 into f0dbf72 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@paazmaya
Copy link
Owner

paazmaya commented Dec 2, 2019

Hi, Thank you for the contribution.

How about test cases, can you add those with fixtures?

Also, please "sign-off" the commits, in order to mark the contibution as a contribution. The DCO checks for that.

@hnzlmnn hnzlmnn mentioned this pull request Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #31 into master will decrease coverage by 0.82%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   90.19%   89.37%   -0.83%     
==========================================
  Files           6        6              
  Lines         153      160       +7     
==========================================
+ Hits          138      143       +5     
- Misses         15       17       +2
Impacted Files Coverage Δ
bin/shuji.js 83.33% <ø> (ø) ⬆️
index.js 100% <ø> (ø) ⬆️
lib/read-sources.js 92% <84.61%> (-8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0dbf72...8c520ab. Read the comment docs.

Signed-off-by: Malte Heinzelmann <[email protected]>
Signed-off-by: Malte Heinzelmann <[email protected]>
@paazmaya
Copy link
Owner

@hnzlmnn hi, sorry for not coming back to this faster, but the test cases are still missing in this PR, please add example files as fixtures and resulting files as expected, than assert between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants