Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: hydralauncher-deb #6921

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add: hydralauncher-deb #6921

wants to merge 6 commits into from

Conversation

raik199x
Copy link

@raik199x raik199x commented Jan 19, 2025

Progress

  • Edit packagelist
  • Add initial pacscript
  • Contact devs
  • Add maintainer to pacscript

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Jan 19, 2025
@raik199x raik199x requested a review from Elsie19 January 24, 2025 16:07
@raik199x
Copy link
Author

Should I contact the developers and/or add myself as a maintainer?

@Elsie19
Copy link
Member

Elsie19 commented Jan 31, 2025

Your choice.

@raik199x
Copy link
Author

raik199x commented Feb 3, 2025

Your choice.

I'm following your documentation on pull requests, and your team wrote this:

"Then, if a reviewer tells you to contact the developer of the pacscript you have made, make an issue on whatever platform the developer uses, such as GitHub, or GitLab, etc."

So it is unclear to me if I need to do this, I was expecting at least someone to write me that I do not need to do this.

And okay, I'll add myself as a maintainer soon.

@Elsie19
Copy link
Member

Elsie19 commented Feb 3, 2025

Your choice.

I'm following your documentation on pull requests, and your team wrote this:

"Then, if a reviewer tells you to contact the developer of the pacscript you have made, make an issue on whatever platform the developer uses, such as GitHub, or GitLab, etc."

So it is unclear to me if I need to do this, I was expecting at least someone to write me that I do not need to do this.

And okay, I'll add myself as a maintainer soon.

I know it's unclear and I'll work on changing it later, but as of a while, it's just been up to the person who opens the PR.

@raik199x
Copy link
Author

raik199x commented Feb 3, 2025

Your choice.

I'm following your documentation on pull requests, and your team wrote this:
"Then, if a reviewer tells you to contact the developer of the pacscript you have made, make an issue on whatever platform the developer uses, such as GitHub, or GitLab, etc."
So it is unclear to me if I need to do this, I was expecting at least someone to write me that I do not need to do this.
And okay, I'll add myself as a maintainer soon.

I know it's unclear and I'll work on changing it later, but as of a while, it's just been up to the person who opens the PR.

Updated.

I won't write to the maintainers since it's optional. Thanks for your time.

@Elsie19
Copy link
Member

Elsie19 commented Feb 4, 2025

Your choice.

I'm following your documentation on pull requests, and your team wrote this:

"Then, if a reviewer tells you to contact the developer of the pacscript you have made, make an issue on whatever platform the developer uses, such as GitHub, or GitLab, etc."

So it is unclear to me if I need to do this, I was expecting at least someone to write me that I do not need to do this.

And okay, I'll add myself as a maintainer soon.

Just to give you some context to why it says that: back when we were a small package manager with not a lot of users, we wanted maintainers to be active in going out to upstream maintainers and make them aware of us (and possibly have them co-maintain it). Now it's not needed as much and should be an optional thing solely for maintainers if they really want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants