Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: sayonara #6945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add: sayonara #6945

wants to merge 2 commits into from
+97 −0

Conversation

villamorrd
Copy link
Contributor

Progress

  • Edit packagelist
  • Add initial pacscript
  • Contact devs
  • Add maintainer to pacscript

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Jan 25, 2025
Elsie19
Elsie19 requested changes Jan 25, 2025
View reviewed changes
packages/sayonara/sayonara.pacscript Outdated
gives="sayonara"
repology=("project: ${gives}")
arch=('amd64')
pkgver="1.10.0-stable1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how this looks a lot like a pkgrel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it's versioned in upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but then we'd get 1.10.0-stable1-pacstall1 as the logged version in dpkg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be fine? 23181dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie19 Elsie19 Elsie19 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@villamorrd villamorrd

Labels
Package Add Use this to request a package to be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@villamorrd @Elsie19