feat: add matchers for ISO 8601 date format #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
force-pushed
the
feature/iso-dates
branch
from
8b38b93
to
96bac1d
Compare
This introduces `pact.Format.iso_8601_datetime()` method to match a string for a full ISO 8601 Date. This method does not do any sort of date validation, only checks if the string is according to the ISO 8601 spec. It differs from `pact.Format.timestamp`, `pact.Format.date` and `pact.Format.time` implementations in that it is more stringent and tests the string for exact match to the ISO 8601 dates format. Without `with_ms` parameter will match string containing ISO 8601 formatted dates as stated bellow: * 2016-12-15T20:16:01 * 2010-05-01T01:14:31.876 * 2016-05-24T15:54:14.00000Z * 1994-11-05T08:15:30-05:00 * 2002-01-31T23:00:00.1234-02:00 * 1991-02-20T06:35:26.079043+00:00 Otherwise, ONLY dates with milliseconds will match the pattern: * 2010-05-01T01:14:31.876 * 2016-05-24T15:54:14.00000Z * 2002-01-31T23:00:00.1234-02:00 * 1991-02-20T06:35:26.079043+00:00 This change aims to bring the capabilities of the python library into alignment with pact-foundation/docs.pact.io#88, since the existing functionality is a bit liberal and allows tests to pass even in cases where the dates do not conform to the ISO 8601 spec.
sergeyklay
force-pushed
the
feature/iso-dates
branch
from
fff6413
to
4919772
Compare
mefellows
approved these changes
Apr 2, 2023
|
@mefellows I'll definitely fix this, thank you for your comment. However, I would like to address it in a separate pull request. The issue is that there is currently hardcoded logic in all matchers, and I'd prefer to make a single, unified change to address this. |
|
Absolutely! Let's not hold up this change for that. |
YOU54F
approved these changes
Apr 28, 2023
|
Nice one, we've got a flakey build, but you get a mergey merge ( i just got one merging a docco change :( ) |
|
also thanks for updating the readme and adding a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
pact.Format.iso_8601_datetime()method to match a string for a full ISO 8601 Date.This method does not do any sort of date validation, only checks if the string is according to the ISO 8601 spec.
It differs from
pact.Format.timestamp,pact.Format.dateandpact.Format.timeimplementations in that it is more stringent and tests the string for exact match to the ISO 8601 dates format.Without
with_msparameter will match string containing ISO 8601 formatted dates as stated bellow:Otherwise, ONLY dates with milliseconds will match the pattern:
This change aims to bring the capabilities of the python library into alignment with pact-foundation/docs.pact.io#88, since the existing functionality is a bit liberal and allows tests to pass even in cases where the dates do not conform to the ISO 8601 spec.