fix(v3): defer setting pact broker source #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting that Pact broker source, the verifier name _must_ be set; however, the FFI call to set this is deferred until the `verify()` call. The setting of the Pact broker source (which itself depends on knowing the verifier name) must therefore be also deferred. Signed-off-by: JP-Ellis <[email protected]>
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
===================================
- Coverage 78% 77% -1%
===================================
Files 31 31
Lines 3665 3668 +3
===================================
Hits 2859 2859
- Misses 806 809 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Defer setting the Pact broker source through the FFI until the
verify()call is made.🚨 Breaking Changes🔥 Motivation
When setting that Pact broker source, the verifier name must be set; however, the FFI call to set this is deferred until the
verify()call. The setting of the Pact broker source (which itself depends on knowing the verifier name) must therefore be also deferred.🔨 Test Plan
🔗 Related issues/PRs