Fix Linter and htmlproofer #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Oct 18, 2024
| @@ -1,21 +0,0 @@ | |||
| import os | |||
| import sys | |||
There was a problem hiding this comment.
please keep this file.
This script check images paths.
| - Validate HTML5 | ||
|
|
||
| ```bash | ||
| pip install html5validator |
There was a problem hiding this comment.
Please add this into yarn as new target. Since we have yarn better we use it.
b00f
reviewed
Oct 19, 2024
| "prettier:setup": "yarn add prettier prettier-plugin-go-template --dev", | ||
| "prettier": "prettier --write \"content/**/*.md\" \"layouts/**/*.html\"", | ||
| "lint:md:setup": "gem install mdl", | ||
| "lint:md": "mdl --style=.mdlrc.rb ./content", | ||
| "lint:yml:setup": "pip install --upgrade yamllint", | ||
| "lint:yml": "yamllint ./data ./content", | ||
| "exif": "for i in $(find ./ -name node_modules -prune *.png -o -name *.gif -o -name *.jpg -o -name *.jpeg); do echo \"Processing $i\"; exiftool -all= \"$i\"; done" |
b00f
reviewed
Oct 19, 2024
| "htmlproofer:setup": "gem install html-proofer", | ||
| "htmlproofer": "htmlproofer --swap-urls 'http\\://localhost\\:1313:' --ignore-status-codes 999,429 --enforce-https false --ignore-urls /cdn./,/discord.gg/,/t.me/,/x.com/,/github.com/,/ietf.org/ ./public", | ||
| "htmlproofer:setup": "gem install html-proofer -v 4.3", | ||
| "htmlproofer": "htmlproofer --swap-urls 'http://localhost:1313' --ignore-status-codes '999,429,403,0' --ignore-urls=/github.com/,/cdn./,/discord.gg/,/t.me/,/tools.ietf.org/,/www.googletagmanager.com/,/googletagmanager.com/ ./public", |
There was a problem hiding this comment.
why did you remove --enforce-https false ?
There was a problem hiding this comment.
I think it's better to have all links HTTPS to prevent browser HTTP insecure error from our website.
|
Closing the PR, it is replace by #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix linter and htmlproofer