fix(grpc): add stacktrace to locate panic (#1333)

pactus-project · Jun 10, 2024 · 9088254 · 9088254
1 parent 8a73a3e
commit 9088254
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/www/grpc/middleware.go b/www/grpc/middleware.go
@@ -2,7 +2,7 @@ package grpc
 
 import (
 	"context"
-	"log"
+	"runtime/debug"
 
 	rec "github.com/grpc-ecosystem/go-grpc-middleware/recovery"
 	"github.com/pactus-project/pactus/util/htpasswd"
@@ -28,10 +28,15 @@ func BasicAuth(storedCredential string) grpc.UnaryServerInterceptor {
 	}
 }
 
-func Recovery() grpc.UnaryServerInterceptor {
+func (s *Server) Recovery() grpc.UnaryServerInterceptor {
 	recovery := func(p any) (err error) {
 		err = status.Errorf(codes.Unknown, "%v", p)
-		log.Println("recovery: panic triggered in grpc server", "error", err)
+		stackTrace := debug.Stack()
+		s.logger.Error(
+			"recovery panic triggered in grpc server",
+			"error", err,
+			"stacktrace", string(stackTrace),
+		)
 
 		return err
 	}

diff --git a/www/grpc/middleware_test.go b/www/grpc/middleware_test.go
@@ -72,7 +72,9 @@ func TestBasicAuth(t *testing.T) {
 }
 
 func TestGrpcRecovery(t *testing.T) {
-	interceptor := Recovery()
+	s := setup(t, nil)
+
+	interceptor := s.server.Recovery()
 
 	_, err := interceptor(context.Background(), nil, &grpc.UnaryServerInfo{}, mockUnaryPanicHandler)
 	if status.Code(err) != codes.Unknown {

diff --git a/www/grpc/server.go b/www/grpc/server.go
@@ -72,7 +72,7 @@ func (s *Server) startListening(listener net.Listener) error {
 		opts = append(opts, BasicAuth(s.config.BasicAuth))
 	}
 
-	opts = append(opts, Recovery())
+	opts = append(opts, s.Recovery())
 
 	grpcServer := grpc.NewServer(grpc.ChainUnaryInterceptor(opts...))