-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grpc): add fee config to get node info api response #1561
feat(grpc): add fee config to get node info api response #1561
Conversation
@@ -91,7 +91,7 @@ func NewNode(genDoc *genesis.Genesis, conf *config.Config, | |||
if conf.GRPC.BasicAuth != "" { | |||
enableHTTPAuth = true | |||
} | |||
grpcServer := grpc.NewServer(conf.GRPC, st, syn, net, consMgr, walletMgr) | |||
grpcServer := grpc.NewServer(conf.GRPC, st, syn, net, consMgr, walletMgr, conf.TxPool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b00f What you think we pass just conf
instead part of configuration to gRPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering maybe we can find a better way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's think out of box; gRPC almost have everything. Right?
Why don't we simply give him Node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can give public access to configuration via node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node itself depends on gRPC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node has all modules...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we pass node to gRPC we will encounter cycle import.
I suggest passing conf
as Javad said.
@alidevjimmy In http server you need add fee configuration to node handler. Lines 80 to 118 in 80ea4db
|
…immy/pactus into feat/add-fee-config-to-node-info
It's Done. |
Thanks @alidevjimmy but This PR only adds complexity to the code, without any clear reason. Let's close it. |
Description
This PR adds a node fee config to
GetNodeInfoResponse
ofGetNodeInfo
method.Related issue(s)