Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): create single ed25519 reward address for all validators #1570

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

akbariandev
Copy link
Contributor

@akbariandev akbariandev commented Oct 28, 2024

Description

In these changes, we create 1 reward address (ed25519) instead 7-32 addresses for all validators when initializing a node.

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@akbariandev akbariandev requested review from b00f and Ja7ad October 28, 2024 09:17
@akbariandev akbariandev self-assigned this Oct 28, 2024
@akbariandev akbariandev changed the title feat(init): create one ed25519 reward address for all validators feat(wallet): create one ed25519 reward address for all validators Oct 28, 2024
Copy link
Contributor

@Ja7ad Ja7ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akbariandev Please test it on testnet and localnet then send result of example reward address.

@b00f
Copy link
Collaborator

b00f commented Oct 28, 2024

Is it backward compatible?

Let's say you have a validator without an Ed address. After this change, the node won't start because it looks for an Ed reward address, which does not exist.

@akbariandev
Copy link
Contributor Author

Is it backward compatible?

Let's say you have a validator without an Ed address. After this change, the node won't start because it looks for an Ed reward address, which does not exist.

Fixed in the last commit and tested in localnet with both bls and ed25529 reward addresses. Please review for merge

@Ja7ad
Copy link
Contributor

Ja7ad commented Oct 29, 2024

Is it backward compatible?
Let's say you have a validator without an Ed address. After this change, the node won't start because it looks for an Ed reward address, which does not exist.

Fixed in the last commit and tested in localnet with both bls and ed25529 reward addresses. Please review for merge

Can you check functionality create new validator in GUI and pactus-wallet, When create new validator auto created a bls reward address.

cmd/cmd.go Outdated Show resolved Hide resolved
cmd/cmd.go Outdated Show resolved Hide resolved
@akbariandev
Copy link
Contributor Author

akbariandev commented Oct 29, 2024

All validators get the single new ED25519 address. Also new validator added and after running node, that new validator gets exact single address. The flow tested in cli nad GUI on localnet and testnet. Transfer and bond works fine only rewarding process may need to test more and because of low staking on my test net nodes the reward process testing may get long time.

image

cmd/cmd.go Outdated Show resolved Hide resolved
cmd/gtk/startup_assistant.go Outdated Show resolved Hide resolved
cmd/daemon/init.go Outdated Show resolved Hide resolved
@akbariandev akbariandev changed the title feat(wallet): create one ed25519 reward address for all validators feat(wallet): create single ed25519 reward address for all validators Oct 30, 2024
@akbariandev akbariandev requested review from b00f and Ja7ad October 30, 2024 10:51
@b00f b00f merged commit 86a8ba9 into pactus-project:main Nov 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate 7 to 32 Validators with a Single Reward Account Address During Initial Node Setup
3 participants