-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): create single ed25519 reward address for all validators #1570
feat(wallet): create single ed25519 reward address for all validators #1570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akbariandev Please test it on testnet and localnet then send result of example reward address.
Is it backward compatible? Let's say you have a validator without an Ed address. After this change, the node won't start because it looks for an Ed reward address, which does not exist. |
Fixed in the last commit and tested in localnet with both bls and ed25529 reward addresses. Please review for merge |
Can you check functionality create new validator in GUI and pactus-wallet, When create new validator auto created a bls reward address. |
All validators get the single new ED25519 address. Also new validator added and after running node, that new validator gets exact single address. The flow tested in cli nad GUI on localnet and testnet. Transfer and bond works fine only rewarding process may need to test more and because of low staking on my test net nodes the reward process testing may get long time. |
Description
In these changes, we create 1 reward address (ed25519) instead 7-32 addresses for all validators when initializing a node.
Related issue(s)
If this Pull Request is related to an issue, mention it here.