Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(types): refactor account and validator tests #1613

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Nov 27, 2024

Description

This PR aims to simplify and improve tests by refactoring the GenerateTestAccount and GenerateTestValidator methods. These methods now accept options to construct test accounts and validators with optional parameters.

Related issue(s)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.78082% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (86a8ba9) to head (8038c71).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
+ Coverage   75.07%   76.26%   +1.19%     
==========================================
  Files         234      236       +2     
  Lines       12156    18283    +6127     
==========================================
+ Hits         9126    13944    +4818     
- Misses       2582     3878    +1296     
- Partials      448      461      +13     

@b00f b00f merged commit c7ab5d8 into pactus-project:main Dec 7, 2024
12 checks passed
@b00f b00f deleted the test/acc-val-option branch December 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing a test failure
1 participant