Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Node Dragon bootstrap node #989

Closed
wants to merge 12 commits into from

Conversation

quangtuyen88
Copy link
Contributor

@quangtuyen88 quangtuyen88 commented Jan 30, 2024

Description

adding Node Dragon Bootstrap Node

@kehiy kehiy changed the title added node dragon chore: adding Node Dragon Bootstrap Node Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #989 (cc88f60) into main (b84fd97) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head cc88f60 differs from pull request most recent head 9eb9be1. Consider uploading reports for the commit 9eb9be1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   81.40%   81.46%   +0.06%     
==========================================
  Files         173      173              
  Lines        9190     9190              
==========================================
+ Hits         7481     7487       +6     
+ Misses       1351     1347       -4     
+ Partials      358      356       -2     

@b00f b00f changed the title chore: adding Node Dragon Bootstrap Node chore: add Node Dragon Bootstrap Node Jan 30, 2024
@b00f
Copy link
Collaborator

b00f commented Jan 30, 2024

@quangtuyen88 Thanks

@b00f
Copy link
Collaborator

b00f commented Jan 30, 2024

@quangtuyen88
Kindly resolve the conflicts or submit a new pull request (PR).
Apologies for any inconvenience caused.

@quangtuyen88
Copy link
Contributor Author

Hello @b00f . pls help merge. Thanks

@b00f
Copy link
Collaborator

b00f commented Jan 30, 2024

@quangtuyen88

Kindly resolve the conflicts or submit a new pull request (PR).
Apologies for any inconvenience caused.

@quangtuyen88
Copy link
Contributor Author

solved @b00f

@b00f b00f changed the title chore: add Node Dragon Bootstrap Node chore: add Node Dragon bootstrap node Jan 31, 2024
@b00f
Copy link
Collaborator

b00f commented Jan 31, 2024

@quangtuyen88
Please enable relay and auto NAT services. Read here for more information:
https://github.com/pactus-project/pactus/blob/main/docs/bootstrap.md#bootstrap-node-configuration

@quangtuyen88
Copy link
Contributor Author

Hello @b00f ..i think that's issue with my firewall.. pls very again if it's oke now

@themantre
Copy link
Contributor

@quangtuyen88 It still has conflicts. Close this PR and open a new one please

@themantre themantre closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants