Fix for cascading mailer path being added when using partials in email templates #2233
Conversation
… partials in email templates As per padrino#2231, when using multiple partials within an email template, the mailer name keeps getting added to the file path for each subsequent partial in the same template, resulting in an `Errno::ENOENT: No such file or directory @ rb_sysopen` error. Added a check to `settings.view` in the render routine to see if the mailer path was already in the string before adding it.
|
@CyberFerret Thanks for this. Could you fix this error as part of this PR or a separate, looks related to the mailer. Even better if you could add an extra unit test associated with this fix |
Odd - I just added an 'unless' qualifier to one existing line. The error mentions 'mailer' not being found - could be a dependency error? Was this caused by me forking the repo first in order to test my fix? I am not clear how to resolve this, because it appears to be in a section of the app that I didn't touch. |
|
I understand, I think you are correct that it is somewhat unrelated, however it may be an easy fix and it would be nice to get the build passing in order to merge this. Separately, would you able to look into adding a test associated with this change? |
|
This has been resolved via another PR that one of our developer submitted. |
As per #2231, when using multiple partials within an email template, the mailer name keeps getting added to the file path for each subsequent partial in the same template, resulting in an
Errno::ENOENT: No such file or directory @ rb_sysopenerror.Added a check to
settings.viewin the render routine to see if the mailer path was already in the string before adding it.