-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production declaration files #74
base: master
Are you sure you want to change the base?
Conversation
@davidpvilaca Antes de tudo gostaria muito de agradecer pela sua contribuição!!! Tenho alguns pontos de ressalva para ponderar nela:
Proponho quebrar essa pr nos seguintes pontos:
Por fim tem que mudar esse descritivo da PR. 😄 Se seguir nessa ordem as mudanças acho que fica bem legal. |
const stringify = log => { | ||
if (R.is(String, log)) return log | ||
export const stringify = (log: any) => { | ||
if (typeof log === 'string') return log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fala @davidpvilaca, talvez isso aqui dê problema. 🤔
Manter o comportamento com Ramda tanto aqui, quanto nos outros locais modificados dessa forma é mais seguro
@@ -0,0 +1,25 @@ | |||
const { compilerOptions } = require('./tsconfig.json') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obrigado por colocar Jest 😍
This close #73
Proposed Changes
Motivation and Context
As I said in issue #73 I am using a scribe and I already had to write some types at the root of the my project to get rid of using "any" in everything related to this library.
How Has This Been Tested?
npm run lint
npm test
npm run build
(dist folder checked with .d.ts files)Impactful Changes
Any change or improvement to approve this PR, I am ready to listen