Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type for charge_remainder_fee in getSplitOptionsResponse schema #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renatoastra
Copy link

I identified an issue with the getSplitOptionsResponse schema where the property charge_remainder_fee was incorrectly typed as optional(nullable(string)). This was causing errors when interacting with the API, as the correct type should be optional(nullable(boolean)).

Changes made:

  • Schema update:

    • Corrected the type of charge_remainder_fee from optional(nullable(string)) to optional(nullable(boolean)) in the getSplitOptionsResponse schema.
  • Interface update:

    • Adjusted the corresponding interfaces to reflect this change.

These changes should align the SDK with the API's expected behavior, preventing the type errors that were occurring.

Please review and let me know if any further adjustments are needed. Thanks!

Copy link

⚠️ Este repositório ainda não está catalogado no Backstage. ⚠️

Por favor, catalogue-o seguindo as instruções nesta documentação. [Via VPN].

💁 Qualquer problema ou dúvida, estamos no Slack, basta abrir um ticket no canal #help-foundation-platform.

@brunowego
Copy link

Please, merge it.

@renatoastra
Copy link
Author

@grazielcosta

Boa tarde, pode revisar o PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants