홈화면에서 쓰이는 아티클 리스트 컴포넌트를 추가합니다. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhminme
requested review from
brgndyy,
InSeong-So,
Siihyun and
0uizi0
as code owners
hhhminme
commented
Sep 12, 2023
Comment on lines
+8
to
+12
| Object.entries(params).forEach(([key, value]) => { | ||
| if (value) { | ||
| newSearchParams.append(key, `${value}`); | ||
| } | ||
| }); |
There was a problem hiding this comment.
export interface ArticlesQueryParamsType {
tag?: string;
author?: string;
favorited?: string;
offset?: number;
limit?: number;
}
여기에 사용되는 prams 가 길기 때문에 이를 string 으로 직접 넣어주는 것이 아닌 URLSearchParams를 통해 만들어줍니다.
Comment on lines
+35
to
+43
| <ul className="tag-list"> | ||
| {tagList.map(tag => { | ||
| return ( | ||
| <li className="tag-default tag-pill tag-outline" key={tag}> | ||
| {tag} | ||
| </li> | ||
| ); | ||
| })} | ||
| </ul> |
There was a problem hiding this comment.
차후 하단 태그 컴포넌트를 분리하도록 하겠습니다.
Comment on lines
+3
to
+16
| <div className="feed-toggle"> | ||
| <ul className="nav nav-pills outline-active"> | ||
| <li className="nav-item"> | ||
| <a className="nav-link" href="/"> | ||
| Your Feed | ||
| </a> | ||
| </li> | ||
| <li className="nav-item"> | ||
| <a className="nav-link active" href="/"> | ||
| Global Feed | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
toggle을 추가하였습니다. login 기능연동이 필요할것 같아 로그인 상태를 어떻게 할지 고민해본 다음에 연동해볼게요
Comment on lines
+3
to
+14
| <ul className="pagination"> | ||
| <li className="page-item active"> | ||
| <a className="page-link" href="/"> | ||
| 1 | ||
| </a> | ||
| </li> | ||
| <li className="page-item"> | ||
| <a className="page-link" href="/"> | ||
| 2 | ||
| </a> | ||
| </li> | ||
| </ul> |
There was a problem hiding this comment.
페이지네이션은 tanstack-query-pagenation 을 사용할 수 있지만 Hydration 때 json 직렬화 과정에서 너무 느렸습니다.
상태나 searchParams을 통해 페이지를 관리하고 UseQuery에 바로 넣어줄 예정입니다.
이거 정말 장난 아니네요........ ㅋㅋ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 링크
📖 작업 배경
🛠️ 구현 내용
💡 참고사항
exmaple라는 폴더가 있을 경우https://someDomain/example와 같이 Router를 해주는 폴더인지 눈으로만 보고는 구분이 어렵습니다.🖼️ 스크린샷