Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow notifications on seasonal worlds to be ignored #357

Merged
merged 7 commits into from
Nov 5, 2023
Merged

feat: allow notifications on seasonal worlds to be ignored #357

merged 7 commits into from
Nov 5, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Nov 4, 2023

Work towards #356 (adds seasonalWorld to notification metadata)

@iProdigy iProdigy requested review from pajlada and Felanbird November 4, 2023 16:50
Felanbird
Felanbird approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{
   "type":"CLUE",
   "playerName":"felanbird1",
   "accountType":"NORMAL",
   "dinkAccountHash":"506af75ee4c2848d191f7c110039950d5205531d7140e5d0d1e4315f",
   "clanName":"P i c k l e",
   "seasonalWorld":false,
   "extra":{

@iProdigy iProdigy merged commit 1ce85ce into pajlads:master Nov 5, 2023
4 checks passed
@iProdigy iProdigy deleted the feature/seasonal-metadata branch November 5, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iProdigy @pajlada @Felanbird