Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add leagues notifier for areas, relics, and tasks #366

Merged
merged 21 commits into from
Nov 17, 2023
Merged

feat: add leagues notifier for areas, relics, and tasks #366

merged 21 commits into from
Nov 17, 2023

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Nov 16, 2023 •
edited
Loading

Closes #356

Notifies on:

  • Area unlocked

image

 

  • Relic unlocked

image

 

  • Task completed

image

image

@iProdigy iProdigy marked this pull request as ready for review November 16, 2023 08:33
@Felanbird
Copy link
Member

Felanbird commented Nov 16, 2023 •
edited
Loading

tasks work
task filtering works
relic unlock works
tasks with trophy levelup work bronze->iron

iProdigy
iProdigy commented Nov 16, 2023
View reviewed changes
src/main/java/dinkplugin/notifiers/LeaguesNotifier.java
thresholds.put(56_000, "Dragon");
TROPHY_BY_POINTS = Collections.unmodifiableNavigableMap(thresholds);

TIER_BY_RELIC = Map.ofEntries(
Copy link
Member Author

@iProdigy iProdigy Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR, can switch hardcoded relic names to dynamic lookup from structs/enums: https://discord.com/channels/301497432909414422/419891709883973642/1174650927689506866

Felanbird
Felanbird approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested everything except region unlock, I believe it all works

@iProdigy
Copy link
Member Author

I'll try to get a region unlock tonight before falling asleep to test that branch

@iProdigy
Copy link
Member Author

area notif works

image

pajlada
pajlada requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, two nitpicks is all I could find

src/main/java/dinkplugin/notifiers/data/LeaguesAreaNotificationData.java Show resolved Hide resolved
src/main/java/dinkplugin/notifiers/LeaguesNotifier.java Outdated Show resolved Hide resolved
@iProdigy iProdigy requested a review from pajlada November 17, 2023 19:02
@iProdigy iProdigy merged commit c8d7d50 into pajlads:master Nov 17, 2023
4 checks passed
@iProdigy iProdigy deleted the feature/add-leagues-notifier branch November 17, 2023 19:08
@iProdigy iProdigy mentioned this pull request Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include league messages in a separate notifier type
3 participants
@iProdigy @Felanbird @pajlada