-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composer-install buildpack #2
Merged
sophiewigmore
merged 18 commits into
paketo-buildpacks:main
from
joshuatcasey:jtc/rewrite-composer-install-buildpack
Apr 27, 2022
Merged
Add composer-install buildpack #2
sophiewigmore
merged 18 commits into
paketo-buildpacks:main
from
joshuatcasey:jtc/rewrite-composer-install-buildpack
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatcasey
force-pushed
the
jtc/rewrite-composer-install-buildpack
branch
from
March 31, 2022 16:49
1fa118c
to
89dd157
Compare
sophiewigmore
added
the
status/blocked
This issue has been triaged and resolving it is blocked on some other issue
label
Mar 31, 2022
joshuatcasey
force-pushed
the
jtc/rewrite-composer-install-buildpack
branch
from
April 5, 2022 02:40
89dd157
to
c8f7135
Compare
joshuatcasey
force-pushed
the
jtc/rewrite-composer-install-buildpack
branch
2 times, most recently
from
April 13, 2022 21:46
4ca8887
to
6ddd1bf
Compare
joshuatcasey
force-pushed
the
jtc/rewrite-composer-install-buildpack
branch
from
April 14, 2022 23:34
c437111
to
e783fb1
Compare
joshuatcasey
force-pushed
the
jtc/rewrite-composer-install-buildpack
branch
from
April 15, 2022 03:54
e783fb1
to
86f03cc
Compare
sophiewigmore
removed
the
status/blocked
This issue has been triaged and resolving it is blocked on some other issue
label
Apr 20, 2022
- https://pkg.go.dev/io/ioutil - "As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details."
- Almost all of the err handling should only occurr if there's a problem with the layers directory
Once the linter is fixed, this is goooood to go! |
|
thitch97
approved these changes
Apr 27, 2022
sophiewigmore
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See README. This buildpack runs
composer install
to download and install Composer packages for PHP applications.Resolves #4
Context
Per PHP RFC 0001 we are restructuring the PHP language family of buildpacks to make them more modular, up-to-date, and as a result, maintainable.
TODOs:
See
TODO
section in the README.Issue
This issue is create the composer-install buildpack, but it is blocked on paketo-buildpacks/composer#12
composer
onlyprovide none
andrequire php
andrequire composer
at build-time.[[buildpack.licences]]
section to thebuildpack.toml
.Acceptance
provides none
andrequires php
andrequires composer
Checklist