Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer-install buildpack #2

Conversation

joshuatcasey
Copy link
Contributor

@joshuatcasey joshuatcasey commented Mar 31, 2022

Summary

See README. This buildpack runs composer install to download and install Composer packages for PHP applications.

Resolves #4

Context

Per PHP RFC 0001 we are restructuring the PHP language family of buildpacks to make them more modular, up-to-date, and as a result, maintainable.

TODOs:

See TODO section in the README.

Issue

This issue is create the composer-install buildpack, but it is blocked on paketo-buildpacks/composer#12

  • Rework it: This buildpack will be responsible for resolving, and installing project dependencies using composer only
  • Rename: This buildpack (php-composer) should be renamed to (composer-install)
  • API: The composer-install buildpack should provide none and require php and require composer at build-time.
  • Packit: This buildpack should be written using the packit v2 library.
  • Buildpack API Version: This buildpack should be written using Buildpack API 0.7.
  • Add a [[buildpack.licences]] section to the buildpack.toml.
  • README: Make sure a README is added that conveys context about the buildpack in a manner consistent with other Paketo buildpacks.
  • Support env var configuration instead of buildpack.yml (See PHP buildpack RFC paketo-buildpacks/php-composer#2)

Acceptance

  1. The buildpack provides none and requires php and requires composer
  2. I can use this buildpack in conjunction with the PHP Dist buildpack and Composer buildpack to successfully build some composer app

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@joshuatcasey joshuatcasey force-pushed the jtc/rewrite-composer-install-buildpack branch from 1fa118c to 89dd157 Compare March 31, 2022 16:49
@sophiewigmore sophiewigmore added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Mar 31, 2022
detect.go Outdated Show resolved Hide resolved
detect.go Outdated Show resolved Hide resolved
detect_test.go Outdated Show resolved Hide resolved
detect_test.go Outdated Show resolved Hide resolved
detect_test.go Outdated Show resolved Hide resolved
detect_test.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@joshuatcasey joshuatcasey force-pushed the jtc/rewrite-composer-install-buildpack branch from 89dd157 to c8f7135 Compare April 5, 2022 02:40
@joshuatcasey joshuatcasey marked this pull request as draft April 6, 2022 21:32
@joshuatcasey joshuatcasey force-pushed the jtc/rewrite-composer-install-buildpack branch 2 times, most recently from 4ca8887 to 6ddd1bf Compare April 13, 2022 21:46
@joshuatcasey joshuatcasey force-pushed the jtc/rewrite-composer-install-buildpack branch from c437111 to e783fb1 Compare April 14, 2022 23:34
@joshuatcasey joshuatcasey force-pushed the jtc/rewrite-composer-install-buildpack branch from e783fb1 to 86f03cc Compare April 15, 2022 03:54
@joshuatcasey joshuatcasey marked this pull request as ready for review April 20, 2022 16:00
@sophiewigmore sophiewigmore removed the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Apr 20, 2022
detect_test.go Outdated Show resolved Hide resolved
detect_test.go Outdated Show resolved Hide resolved
build.go Outdated Show resolved Hide resolved
build_test.go Outdated Show resolved Hide resolved
@sophiewigmore sophiewigmore requested a review from a team as a code owner April 27, 2022 20:50
@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Apr 27, 2022
@sophiewigmore
Copy link
Member

Once the linter is fixed, this is goooood to go!

@sophiewigmore
Copy link
Member

Lint Workflows / lintYaml (pull_request) workflow is irrelevant, we can merge without because the regular lint job is fine!

@sophiewigmore sophiewigmore merged commit 29ec8c6 into paketo-buildpacks:main Apr 27, 2022
@joshuatcasey joshuatcasey deleted the jtc/rewrite-composer-install-buildpack branch April 27, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure buildpack: Create composer-install buildpack
3 participants