Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reading buildpack settings and setting them to the right variable #264

Merged

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Oct 4, 2023

Summary

This is a fix on integration tests.
Specifically, here

_, err = toml.NewDecoder(file).Decode(&settings.Buildpack)
we want to store the buildpack.toml on settings but instead we store it on settings.buildpack and as a result the settings.buildpack.Name is an empty string on integration tests. Integration tests pass because we use regular expression whenever we reference to it
MatchRegexp(fmt.Sprintf(`%s \d+\.\d+\.\d+`, settings.Buildpack.Name)),

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner October 4, 2023 08:59
@pacostas pacostas force-pushed the reading-buildpacks-settings-properly branch 2 times, most recently from 1733a48 to 1036dd9 Compare November 1, 2023 10:11
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Jan 19, 2024
@thitch97 thitch97 merged commit d023b4c into paketo-buildpacks:main Jan 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants