-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test latest httpclient release #2348
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
@Override | ||
protected void onBeforeSocketConnect(HttpContext httpContext, HttpHost endpointHost) { | ||
super.onBeforeSocketConnect(httpContext, endpointHost); | ||
httpContext.setAttribute(CONNECT_BEGAN_ATTRIBUTE, System.nanoTime()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love boxing this long
->Long
.
The onBefore
/onAfter
methods don't allow us to collect timing info when requests fail either, since onAfterSocketConnect
is never called in that case
==COMMIT_MSG==
Test latest httpclient release
==COMMIT_MSG==