test invalid things

paleolimbot · Dec 11, 2024 · 00b85c1 · 00b85c1
1 parent 581209c
commit 00b85c1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/s2geography/geography_test.cc b/src/s2geography/geography_test.cc
@@ -277,7 +277,9 @@ TEST(Geography, EncodedShapeIndex) {
 void TestEncodeWKTRoundtrip(const std::string& wkt,
                             const EncodeOptions& options) {
   SCOPED_TRACE(wkt + " / " + ::testing::PrintToString(options) + " (WKT)");
-  WKTReader reader;
+  geoarrow::ImportOptions import_options;
+  import_options.set_check(false);
+  WKTReader reader(import_options);
   std::unique_ptr<Geography> original_geog = reader.read_feature(wkt);
   // Make sure the original geography matches the given WKT
   ASSERT_THAT(*original_geog, WktEquals6(wkt));
@@ -370,4 +372,11 @@ TEST(Geography, EncodeRoundtrip) {
   }
 }
 
+TEST(Geography, EncodeRoundtripInvalid) {
+  EncodeOptions opt;
+  ASSERT_NO_FATAL_FAILURE(
+      TestEncodeWKTRoundtrip("LINESTRING (0 0, 0 0, 1 1)", opt));
+  ASSERT_NO_FATAL_FAILURE(TestEncodeWKTRoundtrip("POLYGON ((0 0, 0 0))", opt));
+}
+
 }  // namespace s2geography
diff --git a/src/s2geography/wkt-writer_test.cc b/src/s2geography/wkt-writer_test.cc
@@ -96,6 +96,15 @@ TEST(WKTWriter, MixedCollection) {
   EXPECT_EQ(wktRoundTrip(wkt), wkt);
 }
 
+TEST(WKTWriter, InvalidPolyline) {
+  WKTReader reader;
+  try {
+    auto geog = reader.read_feature("LINESTRING (0 0, 0 0, 1 1)");
+  } catch (std::exception &e) {
+    EXPECT_EQ(std::string(e.what()), "Vertices 0 and 1 are identical");
+  }
+}
+
 TEST(WKTWriter, InvalidPolygon) {
   WKTReader reader;
   try {