Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update OpenSSL in CMake approach #57

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

paleolimbot
Copy link
Owner

After #53, duckdb-geography fails to configure for me because it didn't like modifying the s2 target. I am wondering if this approach would also work (i.e., modify the s2geography target instead of the s2geometry target).

@paleolimbot
Copy link
Owner Author

@benbovy Any thoughts about this? I can more directly fix the error that I'm getting when building this in duckdb-geography, but this seems like a better approach than modifying the s2 target (unless it doesn't work!)

@benbovy
Copy link
Collaborator

benbovy commented Dec 11, 2024

This seems to work well too for building Spherely Python wheels:

benbovy/spherely#91
https://github.com/benbovy/spherely/actions/runs/12272251514?pr=91

Openssl is already a host explicit dependency in s2geography's conda-forge recipe so I don't see any issue with this approach, which seems better indeed.

@paleolimbot
Copy link
Owner Author

Thank you for giving this a shot! I have a feeling we're not done here (are we ever with CMake?), but hopefully this won't cause you problems.

@paleolimbot paleolimbot merged commit 581209c into main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants