(feat) : Add lab manifest to KenyaEMR 3.x #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for manifets form, used tabs for acttive request and manifest samples
|
Looks good, @Omoshlawi. I have asked Ted if he can guide on the summary panel. It will be much easier to implement |
donaldkibet
requested changes
Jul 22, 2024
packages/esm-lab-manifest-app/src/forms/lab-manifest-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-lab-manifest-app/src/forms/lab-manifest-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-lab-manifest-app/src/forms/lab-manifest-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-lab-manifest-app/src/forms/lab-manifest-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-lab-manifest-app/src/tables/lab-manifest-active-requests.component.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <div className={styles.widgetContainer}> | ||
| <CardHeader title={headerTitle}> | ||
| <div style={{ padding: '10px' }}> |
There was a problem hiding this comment.
If possible extract these styles from the component
packages/esm-lab-manifest-app/src/tables/lab-manifest-table.scss
Outdated
Show resolved
Hide resolved
|
@Omoshlawi, it would be helpful to have more descriptive PR titles going forward and if possible tickets. This will enable us to generate more meaningful release notes and changelogs. Thanks! see |
donaldkibet
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
lab2.mp4
Related Issue
None.
Other
None.