Added kenyaemr providers esm #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Jul 29, 2024
packages/esm-providers-app/src/providers-header/providers-header.scss
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
+25
| const [searchResults, setSearchResults] = useState<any[]>([]); | ||
| const [selectedUser, setSelectedUser] = useState<any | null>(null); | ||
| const [licenseNumber, setLicenseNumber] = useState(''); | ||
| const [expiryDate, setExpiryDate] = useState(''); |
There was a problem hiding this comment.
We already using react-hook-form it would be nice to use it here
| if (response) { | ||
| setSearchResults(response); | ||
| } else { | ||
| console.error('Error fetching users:'); |
There was a problem hiding this comment.
we should be notifying the user about any errors
Comment on lines
+9
to
+20
| const fetcher = async (url) => { | ||
| try { | ||
| const response = await openmrsFetch(url, {}); | ||
| if (!response.ok) { | ||
| throw new Error(`Failed to fetch data: ${response.statusText}`); | ||
| } | ||
|
|
||
| return response.json(); | ||
| } catch (error) { | ||
| throw new Error(`An error occurred while fetching data: ${error.message}`); | ||
| } | ||
| }; |
There was a problem hiding this comment.
no need to define this fetcher if we are hitting openmrs endpoints openmrsfetch will just work fine
Comment on lines
+1
to
+3
| @use '@carbon/styles/scss/spacing'; | ||
| @use '@carbon/styles/scss/type'; | ||
| @import '~@openmrs/esm-styleguide/src/vars'; |
packages/esm-providers-app/src/providers-metrics/providers-metrics-header.component.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| function ProviderMetrics() { | ||
| const { t } = useTranslation(); | ||
| const { response } = getAllProviders(); |
There was a problem hiding this comment.
we should use useSWRImmutable to cache this aggressively since this data doesn't change very often
| min-width: 8.875rem; | ||
|
|
||
| &:active { | ||
| outline: 2px solid var(--brand-03) !important; |
There was a problem hiding this comment.
Why are using !important here
|
I am working on the changes. Pushing it back shotly |
Co-authored-by: Donald Kibet <[email protected]>
…er.scss Co-authored-by: Donald Kibet <[email protected]>
…rics-header.component.tsx Co-authored-by: Donald Kibet <[email protected]>
…rics-header.component.tsx Co-authored-by: Donald Kibet <[email protected]>
…harged.component.tsx Co-authored-by: Donald Kibet <[email protected]>
Co-authored-by: Donald Kibet <[email protected]>
Co-authored-by: Donald Kibet <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Added Providers ESM
Screenshots
None.
Related Issue
None.
Other
None.