Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Cho) Fix schema editor layout and hook conventions #507

Merged
merged 8 commits into from
Jan 13, 2025
Merged

(Cho) Fix schema editor layout and hook conventions #507

merged 8 commits into from
Jan 13, 2025

Conversation

Ogollah
Copy link
Contributor

@Ogollah Ogollah commented Dec 9, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

What does this PR do?

  • Ensures the component layout adjusts appropriately on smaller screens.
  • Updates size and spacing to use Carbon design tokens for consistency with the design system.
  • Renames useStandardSchema to useExemptionSchema
  • Remove duplicate heading

Screenshots

###New video
new.webm

None.

Related Issue

None.

Other

None.

@Ogollah Ogollah requested a review from donaldkibet December 9, 2024 13:00
@donaldkibet
Copy link
Contributor

cc @Ogollah are you still actively working on this

@ojwanganto
Copy link
Contributor

Kindly rename to PR to reflect the fix it's providing

@Ogollah
Copy link
Contributor Author

Ogollah commented Jan 9, 2025

cc @Ogollah are you still actively working on this

Yes this was completed

@Ogollah Ogollah changed the title (Cho) style responsive hook conventions (Cho) Fix schema editor layout and hook conventions Jan 9, 2025
@ojwanganto
Copy link
Contributor

Please resolve the conflicts. Also, share a screenshot/video showing the latest work.

@Ogollah Ogollah force-pushed the cho-tyle-responsive-hook-conventions branch from 23a44e7 to 3a5128b Compare January 9, 2025 18:05
donaldkibet
donaldkibet previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ogollah please fix the failing build

@Ogollah
Copy link
Contributor Author

Ogollah commented Jan 13, 2025

@Ogollah please fix the failing build

This is a new dependency that has been added but is failing to build.

@donaldkibet donaldkibet force-pushed the cho-tyle-responsive-hook-conventions branch from 3a5128b to 4d8abb2 Compare January 13, 2025 15:42
@donaldkibet donaldkibet force-pushed the cho-tyle-responsive-hook-conventions branch from 4d8abb2 to b219a52 Compare January 13, 2025 15:53
@donaldkibet donaldkibet merged commit db5f137 into palladiumkenya:main Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojwanganto ojwanganto ojwanganto left review comments

@donaldkibet donaldkibet donaldkibet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ogollah @donaldkibet @ojwanganto