Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Follow-Up PR: Resolve 404 Error Caused by Conflicting UUIDs in Mortuary esm #537

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

its-kios09
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

I tested the fix by proxying the dev server to ensure it works correctly.

Screenshots

waiting
discharged

None.

Related Issue

None.

Other

None.

@its-kios09 its-kios09 requested a review from Omoshlawi January 10, 2025 00:26
"clockingIn": "Clocking in",
"clockingOut": "Clocking Out",
"clockOut": "Clock Out",
"clockInTime": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

gender: patient?.person?.person?.gender || t('unknownGender', '--'),
age: patient?.person?.person?.age || t('unknownAge', '--'),
identifier: openMrsId,
deathDate: formatDateTime(patient?.person?.person?.deathDate) || t('nullDate', '--'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donaldkibet @makombe - must the nullDate be translatable? Is that the practice?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am sure there are exceptions for translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants