(feat): edit user role scope #561
Open
+222
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Jan 21, 2025
packages/esm-admin-app/src/components/users/manage-users/user-management.workspace.tsx
Show resolved
Hide resolved
|
@patryllus @makombe - how best can we fully qualify the inventory location and the enable and permanent settings? They look hanging and may not be straightforward to any new user.
|
Ogollah
force-pushed
the
feat-edit-user-role-scope
branch
from
a93b96f to
dd9e30c
Compare
…ory location to stock location
Ogollah
force-pushed
the
feat-edit-user-role-scope
branch
from
cc7612b to
5650cd0
Compare
|
@donaldkibet are we good to go on this? |
donaldkibet
requested changes
Jan 23, 2025
packages/esm-admin-app/src/api.ts
Outdated
| limit?: number | null; | ||
| } | ||
|
|
||
| export function toQueryParams<T extends ResourceFilterCriteria>( |
There was a problem hiding this comment.
why do we need to introduce this here, we can easy just specify the rest representation we want. IMO the community has always preferred to use the actual representation needed for most endpoints and we should stick to that convention
Ogollah
force-pushed
the
feat-edit-user-role-scope
branch
from
11f6cdb to
113d352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
What doe this PR do?
Screenshots
editRoleScope.webm
Screencast.from.22-01-2025.11.20.35.ASUBUHI.webm
None.
Related Issue
None.
Other
None.