Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) : use framework @carbon/react version #562

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

donaldkibet
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Use carbon version provided by core, this results in less bundled assets and also ensure UI consistency. e.g Modals should work well.

Screenshots

After Fix

Screenshot 2025-01-21 at 18 09 44

Before

Screenshot 2025-01-21 at 18 09 38

Related Issue

None.

Other

None.

cc @amosmachora this should fix the modal UI

@donaldkibet donaldkibet changed the title Chore/carbondeps (chore) : use framework @carbon/react version Jan 21, 2025
Copy link
Collaborator

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donaldkibet

@makombe makombe merged commit 2a96b0e into main Jan 21, 2025
4 checks passed
@makombe makombe deleted the chore/carbondeps branch January 21, 2025 16:33
@amosmachora
Copy link
Collaborator

perfect @donaldkibet . Feel appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants