KHP3-7349-Implement Side navs and Nav groups with icons #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
previously approved these changes
Jan 24, 2025
| import React from 'react'; | ||
| import { BrowserRouter } from 'react-router-dom'; | ||
| import { LinkExtension } from './link-extension.component'; | ||
| import { CarbonIconType } from '@carbon/react/icons'; |
There was a problem hiding this comment.
Suggested change
| import { CarbonIconType } from '@carbon/react/icons'; | |
| import { type CarbonIconType } from '@carbon/react/icons'; |
| } | ||
| }, | ||
| { | ||
| "component": "diagnosticsRoot", |
There was a problem hiding this comment.
should this be investigation
There was a problem hiding this comment.
i was naming them according to the names used in design
donaldkibet
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
nav-refactor.mp4
Related Issue
https://thepalladiumgroup.atlassian.net/browse/KHP3-7349
https://thepalladiumgroup.atlassian.net/browse/KHP3-7348
None.
Other
None.