Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add side nav with shortcut to other pages #59

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Conversation

CynthiaKamau
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

side nav

Screenshots

None.

Related Issue

None.

Other

None.

@CynthiaKamau CynthiaKamau marked this pull request as draft November 20, 2023 15:44
@donaldkibet
Copy link
Contributor

donaldkibet commented Nov 20, 2023

Thanks @CynthiaKamau from the sessions we have had today. I think we can re-organize our landing page to contain these shortcuts in addition to the active visits. Seems clinicians appreciate 3.x better. cc @ojwanganto @makombe

@ojwanganto
Copy link
Contributor

ojwanganto commented Nov 20, 2023 via email

@CynthiaKamau
Copy link
Contributor Author

We are also dealing with change management issues and we need to hear from users as well as synthesize the feedback that we get from them. Not everything we push will be accepted, and not everything they ask for is valid :)

On Mon, Nov 20, 2023 at 7:07 PM Donald Kibet @.> wrote: Thanks @CynthiaKamau https://github.com/CynthiaKamau from the sessions we have had today. I think we can re-organize out landing page to contain these shortcut in addition to the active visits. Seems clinicians appreciate 3.x better. — Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQPZVP2XXT53OHIA4ZG4WTYFN525AVCNFSM6AAAAAA7TEAQGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGM2TKNJTGE . You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes for this pr to work, we need the nav header to resize based on the contents inside, something like this @denniskigen

@CynthiaKamau CynthiaKamau marked this pull request as ready for review December 15, 2023 13:37
@CynthiaKamau CynthiaKamau force-pushed the custom-app-slot branch 2 times, most recently from bd9db6a to 60dbd93 Compare December 17, 2023 15:02
@ojwanganto
Copy link
Contributor

@denniskigen what do we need to do to have this in?

@donaldkibet
Copy link
Contributor

donaldkibet commented Dec 23, 2023

Kapture.2023-12-23.at.22.43.03.mp4

Updated with the required changes, the remaining part is the order of the app-menu icon on primary-navigation

@donaldkibet donaldkibet merged commit 66fcda9 into main Dec 23, 2023
6 checks passed
@donaldkibet donaldkibet deleted the custom-app-slot branch December 23, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants