Added the reason why sample is likely to fail if added to manifest #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojwanganto
requested changes
Aug 8, 2024
| @@ -292,7 +292,9 @@ public Set<SimpleObject> getActiveViralLoadOrdersNotInManifest(Integer manifestI | |||
| Order o = orderService.getOrder(orderId); | |||
| if (o != null) { | |||
| SimpleObject ret = new SimpleObject(); | |||
| ret.put("hasProblem", checkIfOrderHasAProblem(o, LabManifest.VL_TYPE)); | |||
| SimpleObject problems = checkIfOrderHasAProblem(o, LabManifest.VL_TYPE); | |||
| ret.put("hasProblem", problems.get("hasProblem")); | |||
There was a problem hiding this comment.
can we just have one property called validationMessage for the two properties. The frontend can then check if validationMessage is null and displays the message
There was a problem hiding this comment.
This is important for backward compatibility with 2.x. Maybe we can remove it after full migration to 3.x.
| @@ -333,7 +335,9 @@ public Set<SimpleObject> getActiveEidOrdersNotInManifest(Integer manifestId, Dat | |||
| Order o = orderService.getOrder(orderId); | |||
| if (o != null) { | |||
| SimpleObject ret = new SimpleObject(); | |||
| ret.put("hasProblem", checkIfOrderHasAProblem(o, LabManifest.EID_TYPE)); | |||
| SimpleObject problems = checkIfOrderHasAProblem(o, LabManifest.EID_TYPE); | |||
| ret.put("hasProblem", problems.get("hasProblem")); | |||
There was a problem hiding this comment.
This is important for backward compatibility with 2.x. Maybe we can remove it after full migration to 3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the reason why sample is likely to fail if added to manifest