fix: Increase token name validation length and perf improvement when processing #11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
memoyil
commented
Jan 28, 2025
| const add = `${(error as any).dataPath} ${error.message ?? ''}` | ||
| return memo.length > 0 ? `${memo}; ${add}` : `${add}` | ||
| }, '') ?? 'unknown error' | ||
| if (json.tokens) { | ||
| remove<TokenInfo>(json.tokens, (token) => { | ||
| return !tokenListValidator({ ...json, tokens: [token] }) |
There was a problem hiding this comment.
no need to do process all token one by one since in error message indices can be obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having token to be filtered out for the name which it shouldn't
Token list https://tokens.pancakeswap.finance/pancakeswap-base-default.json validation failed before token filtering: .tokens[43].name should NOT be longer than 40 characters; should match "else" schema
PR-Codex overview
This PR focuses on improving the validation and error handling for fetching and processing token lists in the
pancakeswapschema and thegetTokenListfunction. It enhances the maximum length of token descriptions and introduces better error management during the fetch process.Detailed summary
maxLengthof token description from 40 to 50.responsetojsoningetTokenList.ts.