Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themis to benchmarks #82

Merged
merged 1 commit into from
Feb 21, 2015
Merged

Add themis to benchmarks #82

merged 1 commit into from
Feb 21, 2015

Conversation

atrniv
Copy link
Contributor

@atrniv atrniv commented Jan 31, 2015

Themis has several configuration options which can affect its performance. As such I've added 2 validators in the benchmarks. Themis[minimal] (minimum features enabled) and just Themis (full support for default values enabled).

Signed-off-by: Johny Jose [email protected]

Signed-off-by: Johny Jose <[email protected]>
@atrniv atrniv mentioned this pull request Jan 31, 2015
@gilesbowkett
Copy link
Contributor

some comments on #81.

I'm basically happy to merge this, with a few caveats:

  • I just woke up so I'm going to have an espresso first.
  • You made these changes on your master branch and we really absolutely prefer that changes like this happen on a feature branch and then get merged into master afterwards.
  • "Themis[minimal]" has to become "Themis (minimal)." I can make that change myself, though.

@gilesbowkett
Copy link
Contributor

I'm running json-schema-tests with themis 1.1.5 and still seeing a ton of fails. caveat: I'm about to board an airplane, wrote the harness in a hurry, might be my mistake. but: merge delayed until I'm sure.

@gilesbowkett gilesbowkett merged commit 8847e5e into pandastrike:master Feb 21, 2015
@gilesbowkett
Copy link
Contributor

all good, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants