Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain integration testing recipes in this repo? #143

Closed
cisaacstern opened this issue Nov 18, 2023 · 1 comment · Fixed by #171
Closed

Maintain integration testing recipes in this repo? #143

cisaacstern opened this issue Nov 18, 2023 · 1 comment · Fixed by #171
Assignees

Comments

@cisaacstern
Copy link
Member

In pangeo-forge-recipes we have an examples/ directory which contains a functional feedstock, which is in turn used for integration testing.

Here, we test against an actual GitHub repo (pforgetest/gpcp-from-gcs-feedstock). I wonder if we should abandon this in favor of maintaining test recipes locally in this repo?

I ask because it's feeling a bit tedious, and opaque, to me to need to update an external repo when we want to adjust what is tested. (E.g., for #139, we need a dict_object test case, but that will not actually be part of the PR, because the test case will end up in the external test feedstock.)

@cisaacstern
Copy link
Member Author

🙏 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants