Move integration testing feedstock to tests directory #171
Conversation
ranchodeluxe
added
test-dataflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 95.93% 95.53% -0.40%
==========================================
Files 14 14
Lines 492 493 +1
==========================================
- Hits 472 471 -1
- Misses 20 22 +2 ☔ View full report in Codecov by Sentry. |
|
Currently looking at the integration tests now 👀 |
ranchodeluxe
removed
the
test-flink
ranchodeluxe
added
the
test-flink
|
Alrighty, this is all up and working |
ranchodeluxe
force-pushed
the
npz/feature/internal-integration-fixtures
branch
from
40f988b to
5907220
Compare
for more information, see https://pre-commit.ci
ranchodeluxe
requested review from
cisaacstern,
abarciauskas-bgse and
ranchodeluxe
| @@ -72,6 +78,15 @@ def test_dataflow_integration(): | |||
|
|
|||
| # okay, time to start checking if the job is done | |||
| show_job = f"gcloud dataflow jobs show {job_id} --format=json".split() | |||
| show_job_errors = [ | |||
There was a problem hiding this comment.
reviewer note: let's use this command to dump logs when job fails so we don't have to use GCP console
| # dictobj runs do not generate any datasets b/c they are not recipes | ||
| # so we've asserted what we can already, just move on | ||
| if recipes_version_ref.endswith("dictobj"): | ||
| return |
There was a problem hiding this comment.
reviewer note: this couldn't have been actually producing output for 0.10.x so I think this is fine
| pfr_version = parse_version(version("pangeo-forge-recipes")) | ||
| if pfr_version >= parse_version("0.10"): | ||
| recipe_version_ref = str(pfr_version) | ||
| recipe_version_ref = "0.10.x" |
There was a problem hiding this comment.
reviewer note:
given that integrate/unit tests only test beginning and end range of versions I made the unilateral decision to just have 0.10.x listed in test-data which I think works fine
…m:pangeo-forge/pangeo-forge-runner into npz/feature/internal-integration-fixtures
ranchodeluxe
removed
test-dataflow
for more information, see https://pre-commit.ci
| # We expect `recipe` to be 1) a beam PTransform or 2) or a a string that leverages the | ||
| # `dict_object:` see `tests/test-data/gpcp-from-gcs/feedstock-0.10.x-dictobj/meta.yaml` | ||
| # as an example | ||
| if isinstance(recipe, PTransform): |
There was a problem hiding this comment.
note to reviewer: zero idea how unit tests for dict-object are passing on main b/c we need the conditional here or they fail like they do on this PR 🤷
There was a problem hiding this comment.
another question @cisaacstern: we have a lot of special logic for dict_object recipes where we seem to not test list recipes. Is the list version deprecated in favor of the dict version?
…m:pangeo-forge/pangeo-forge-runner into npz/feature/internal-integration-fixtures
ranchodeluxe
added
test-dataflow
|
@cisaacstern: this is finally ready to go (will rebase my other one) |
Move integration testing feedstock into this repo to avoid doing the two-phase updates where possible.
Closes #143