-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebasing Yuvi's setup_py
branch with main
#110
base: main
Are you sure you want to change the base?
Conversation
save_main_session doesn't seem to work with flink, and Charles tells me it is meant to be a hack anyway - and this is the better way to go longer term
for more information, see https://pre-commit.ci
""" | ||
file = dedent( | ||
""" | ||
import setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest moving this template out into its own file.
This generation also needs to be watched closely for code injection based attacks.
setuptools.setup( | ||
name='recipe', | ||
version='0.1', | ||
# FIXME: Support all the files we need to here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixme is basically the important part - it should contain all the files we wanna package and send into the runner.
#92