Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In meta_yaml recipes section, dict_objects should be a list element #140

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

cisaacstern
Copy link
Member

This is is a stepping stone between #137 and #139.

It just says that dict_objects, if given, should look like this:

recipes:
  - dict_object: 'recipe:recipes'

and not like this:

recipes:
  dict_object: 'recipe:recipes'

Note the - in the former (correct) example.

This is actually bringing us back into alignment with the original spec, which I (mistakenly) revised in:

pangeo-forge/roadmap@df4b26f

The motivation here is that, just because we have dict_objects as part of the recipe, we should not be limited to having a single dictionary, or possibly from mixing regular recipe declarations with dict_objects (if we want).

Note that the existence of the schema added in #137 makes it easy to reason about what's allowed and what's not allowed! (That information is not longer obscured in dense procedural code, as it was previously.) 😄

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c54759f) 96.09% compared to head (d69b3f7) 96.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   96.09%   96.31%   +0.22%     
==========================================
  Files          15       15              
  Lines         486      489       +3     
==========================================
+ Hits          467      471       +4     
+ Misses         19       18       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern cisaacstern added test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test. labels Nov 18, 2023
@cisaacstern cisaacstern merged commit 90479ab into main Nov 18, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant