Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: streamline pool implementation to reduce duplicated code #350

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

panjf2000
Copy link
Owner

Also, bump up the minimal required Go version from 1.16 to 1.18.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 91.60305% with 22 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (4f33c6e) to head (7852f9e).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
ants.go 91.66% 14 Missing and 5 partials ⚠️
pool_func.go 86.66% 1 Missing and 1 partial ⚠️
worker.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #350      +/-   ##
==========================================
- Coverage   89.95%   89.71%   -0.24%     
==========================================
  Files          11       11              
  Lines        1005      797     -208     
==========================================
- Hits          904      715     -189     
+ Misses         76       62      -14     
+ Partials       25       20       -5     
Flag Coverage Δ
unittests 89.71% <91.60%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 9a1446b into dev Jan 12, 2025
13 checks passed
@panjf2000 panjf2000 deleted the pool-refactor branch January 12, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant